[SPARK-24420][Build][FOLLOW-UP] Upgrade ASM6 APIs#22082
Closed
gatorsmile wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-24420][Build][FOLLOW-UP] Upgrade ASM6 APIs#22082gatorsmile wants to merge 1 commit intoapache:masterfrom
gatorsmile wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
felixcheung
approved these changes
Aug 12, 2018
Member
|
LGTM |
|
Test build #94639 has finished for PR 22082 at commit
|
Member
|
retest this please |
srowen
approved these changes
Aug 12, 2018
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
The change just updates code to actually use ASM6 in these places? OK, pending tests.
|
Test build #94643 has finished for PR 22082 at commit
|
Member
|
retest this please |
Member
|
LGTM. @gatorsmile out of my curiosity, did you run into any issue that asm6 generates older version of bytecode defined in asm5? |
Member
|
retest this please |
|
Test build #94660 has finished for PR 22082 at commit
|
Member
|
Merged into master. Thanks. |
Member
Author
|
@dbtsai Nope. I did not hit any issue. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use ASM 6 APIs after we upgrading it to ASM6.
How was this patch tested?
N/A